imbajin commented on code in PR #3126:
URL: https://github.com/apache/hugegraph/pull/3126#discussion_r3706512730
##########
.github/workflows/server-ci.yml:
##########
@@ -87,6 +87,14 @@ jobs:
hugegraph-server/hugegraph-dist/src/assembly/static \
hugegraph-store/hg-store-dist/src/assembly/static/bin/util.sh
+ - name: Run Java security properties tests
+ if: ${{ env.BACKEND == 'rocksdb' }}
+ run: |
+ mvn package -Dmaven.test.skip=true -pl
hugegraph-server/hugegraph-dist -am -ntp
Review Comment:
⚠️ This step does not execute the newly added
`HugeGraphServerBootstrapTest`: it runs `mvn package -Dmaven.test.skip=true`,
while `run-unit-test.sh` only runs `hugegraph-test` for the memory matrix and
does nothing for RocksDB. As a result, the workflow's RocksDB path validates
only the shell smoke script, not these two unit tests; please add an explicit
`mvn test -pl hugegraph-server/hugegraph-dist -am
-Dtest=HugeGraphServerBootstrapTest` (or include the module in an existing test
command) so the added assertions are exercised in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
