Copilot commented on code in PR #3143:
URL: https://github.com/apache/hugegraph/pull/3143#discussion_r3734351031
##########
hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh:
##########
@@ -26,22 +26,58 @@ mkdir -p "${DOCKER_FOLDER}"
log() { echo "[hugegraph-server-entrypoint] $*"; }
-set_prop() {
- local key="$1" val="$2" file="$3"
+encode_prop_value() {
+ local value="$1" encoded="" char
+ local i
+
+ LC_ALL=C
Review Comment:
`encode_prop_value()` sets `LC_ALL=C` without scoping it, which mutates the
process locale for the rest of the entrypoint after the function returns. This
can subtly change behavior of later `sed`/`grep`/string operations. Prefer
making it function-local.
This issue also appears on line 93 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
