bitflicker64 commented on code in PR #3149:
URL: https://github.com/apache/hugegraph/pull/3149#discussion_r3767825548
##########
docker/README.md:
##########
@@ -168,14 +173,87 @@ To validate local images without Compose replacing them
with remote `latest`:
## 3-Node Cluster Quickstart
+The cluster and the Hubble add-on share one named Docker network so Hubble
+can attach to a running cluster without touching it. Treat that network as a
+trust boundary: PD and Store expose unauthenticated control APIs on it (only
+the Server layer authenticates), and any container on the host can join it
+by declaring the well-known name. One-time setup: write the required
+credentials to a mode-600 `docker/.env` and create the network.
+The cluster file requires both credentials — the admin password enables
+authentication, and every Server replica must share one token secret so a
+token issued by any server validates on all of them. The `:?` guards fire
+on every Compose subcommand, including `down`.
+
+```bash
+(
+ set -eu
+ cd docker
+ command -v openssl >/dev/null 2>&1 || { echo "openssl not found" >&2; exit
1; }
+ [ -e .env ] || install -m 600 /dev/null .env
+ chmod 600 .env
+ # Keep appends on their own lines even if the file was hand-edited.
+ [ ! -s .env ] || [ -z "$(tail -c1 .env)" ] || printf '\n' >> .env
+ pat='^[[:space:]]*(export[[:space:]]+)?'
+ if ! grep -Eq "${pat}HUGEGRAPH_ADMIN_PASSWORD=" .env; then
Review Comment:
Addressed in . The validator now isolates unset and empty admin/token cases,
checks the error names the intended variable, and the setup block validates
existing credentials rather than treating a present-but-empty or short value as
complete. Short token values now fail with a repair message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]