bitflicker64 commented on PR #3149: URL: https://github.com/apache/hugegraph/pull/3149#issuecomment-5388512278
Pushed `6b6c3a3c`. All four blocking findings from the last review are fixed in this PR rather than deferred, and the PR description is updated to match. - Auth false-green: images pull by default and Server readiness requires 401 unauthenticated plus 200 authenticated, so an image that ignores `PASSWORD` never becomes healthy. - Control plane: PD, Store, and Server ports bind to `127.0.0.1`, widened only through `HUGEGRAPH_CONTROL_PLANE_HOST` / `HUGEGRAPH_SERVER_PUBLISH_HOST`. - Advertised addresses: each replica's PD-registered URL is configurable, defaults unchanged. - Render-only CI: a live smoke job starts the cluster, attaches Hubble, and asserts the above. The cluster also goes back to being authenticated by default, per your point that this is the file people copy. Running without auth is now an explicit opt-in, `docker-compose-3x3.non-auth.yml` plus a matching Hubble properties file, documented beside the default flow with a copy-paste prompt for people who hand this to an assistant. Tested on a clean Docker host, from zero images: 9/9 healthy, 401/200 on all three replicas, ports on loopback, three PD peers and three Stores Up, Hubble attached without recreating a single cluster container, H2 state surviving recreation across both flows, and the non-auth path returning 200 with no credentials anywhere in the container environment. Testing caught three bugs that rendering never would have, one of them a half-authenticated cluster where only `server0` lost its credentials because `!reset` does not survive a YAML anchor on every Compose version. That one is the clearest argument for the smoke job, so I would rather keep it than trim it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
