imbajin commented on code in PR #3182:
URL: https://github.com/apache/hugegraph/pull/3182#discussion_r3917927424
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java:
##########
@@ -803,7 +804,8 @@ protected Iterator<Vertex> queryVerticesByIds(Object[]
vertexIds, boolean adjace
if (!query.empty()) {
// Query from backend store
query.mustSortByInput(false);
- Iterator<HugeVertex> it = this.queryVerticesFromBackend(query);
+ Iterator<HugeVertex> it =
+ this.queryValidVerticesFromBackend(query);
Review Comment:
‼️ `queryVerticesByIds()` now uses `queryValidVerticesFromBackend()` at this
call site, and that wrapper applies `invalidRecord()` with the default
`showHidden=false`. This method is also used by `queryTaskInfos(id)`
(`StandardTaskScheduler.findTask()`), while task records use the hidden label
`~task` (`HugeTask.P.TASK = Hidden.hide("task")`). Consequently internal task
lookup returns null: exact-head `EdgeCoreTest#testQueryByTextContainsProperty`
fails on the first index-label `.create()` with `NotFoundException: Can't find
task with id '1'`, while the base commit passes; the CI server/hstore failures
show the same missing-task pattern. Keep task/server ID lookups on the raw or
an explicit `showHidden(true)` path, and add a regression for waiting on a
schema task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
