imbajin commented on code in PR #3185: URL: https://github.com/apache/hugegraph/pull/3185#discussion_r3926064340
########## hugegraph-store/docs/deployment-guide.md: ########## @@ -719,7 +719,7 @@ environment: ``` **Startup ordering** is enforced via `depends_on` with `condition: service_healthy`: -1. PD nodes start first and must pass healthchecks (`/v1/health`) +1. PD nodes start first and must pass healthchecks (`/v1/ready`, answered `200` only once the PD sees a raft leader) Review Comment: 🧹 This line says the `depends_on` healthchecks gate on `/v1/ready`, but the compose files in this repository still probe `/v1/health` (`docker/docker-compose-hstore.yml:47` and `docker/docker-compose-3pd-3store-3server.yml:40`). `docker/README.md:211-213` in the same PR explicitly documents that choice, so the deployment guide currently tells operators a readiness gate exists when it does not. Please either keep this as `/v1/health` with a note that it is liveness-only, or update both compose healthchecks with body matching and image-version compatibility before documenting `/v1/ready` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
