imbajin commented on code in PR #3189:
URL: https://github.com/apache/hugegraph/pull/3189#discussion_r3930703534


##########
docker/test-compose.sh:
##########
@@ -21,6 +21,7 @@ set -Eeuo pipefail
 DOCKER_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PASSWORD="ci-compose-password"
 SECRET="0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"
+PD_SECRET="ci-compose-pd-secret"

Review Comment:
   ‼️ Please also pass `HG_PD_AUTH_SECRET_KEY="${PD_SECRET}"` through 
`compose_active` (or route the smoke path through `compose_auth`). The new 
secret is currently supplied only by `compose_auth` for render; `smoke` calls 
`compose_active` at lines 347-349, so the hstore smoke cannot interpolate 
`docker-compose-hstore.yml` and fails before testing the stack. This is 
reproduced on the exact head by the latest `build-server (rocksdb, 11)` run 
above, which reports `HG_PD_AUTH_SECRET_KEY` missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to