contrueCT commented on PR #3184: URL: https://github.com/apache/hugegraph/pull/3184#issuecomment-5692551993
@SebastianGruza @imbajin I think it makes sense to merge #3184 before #2994. The change here is relatively isolated: it avoids pushing sysprop-only range conditions to HStore when those constraints are already covered by the key range, while user-property residual conditions are still pushed down. Also, copying the `ConditionQuery` before trimming it avoids mutating the query still used by the core layer. More importantly, #3184 removes an existing HStore failure unrelated to #2994. Without it, the HStore regression for #2994 is partially blocked by #3090, which makes failures harder to attribute. So I suggest merging #3184 first, then rebasing #2994 on the latest master and rerunning the HStore/RocksDB regression matrix. #3090 should still remain open since #3184 is only a mitigation for the underlying codec issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
