bitflicker64 commented on code in PR #492: URL: https://github.com/apache/hugegraph-doc/pull/492#discussion_r4034016278
########## content/cn/docs/quickstart/computing/hugegraph-vermeer.md: ########## @@ -51,7 +64,7 @@ networks: ``` 修改 docker-compose.yaml -- **Volume**：例如将两处 ~/:/go/bin/config 改为 /home/user/config:/go/bin/config（或您自己的配置目录）。 +- **Volume**：将两处 `~/.config:/go/bin/config` 改为 `/home/user/config:/go/bin/config`（或上面准备的配置目录）。 Review Comment: 🧹 Same gap as on the English page. `docker-compose up -d` runs in the Vermeer root, where `vermeer/docker-compose.yaml` already exists. That file has no `6688:6688` mapping for `vermeer-master`, and both of its services mount `~/:/go/bin/config`, so this bullet names a string that is not in the file, and the host `curl` check and the Python client cannot reach port 6688. Requested change: tell readers to add `ports: ["6688:6688"]` to `vermeer-master` and to point both volumes at the prepared config directory, even when they use the repository's own `docker-compose.yaml`. ########## content/en/docs/quickstart/computing/hugegraph-vermeer.md: ########## @@ -14,45 +14,58 @@ The master is responsible for communication, forwarding, and aggregation, with m The framework's runtime configuration can be passed via command-line parameters or specified in configuration files located in the `config/` directory. The `--env` parameter can specify which configuration file to use, e.g., `--env=master` specifies using `master.ini`. Note that the master needs to specify the listening port, and the worker needs to specify the listening port and the master's `ip:port`. +The default master HTTP port is `6688` for REST API and Python clients. Workers connect to the master through gRPC port `6689`. The Docker examples below publish HTTP with `6688:6688`; keep `http_peer=0.0.0.0:6688` in the master configuration. + ### 1.2 Running Method +For both Docker options below, prepare a host configuration directory containing the provided `master.ini` and `worker.ini` files. In the existing `[default]` section of `worker.ini`, change `master_peer` as follows, keeping the other settings: + +```ini +[default] +master_peer=vermeer-master:6689 +``` + +Inside the worker container, the shipped `127.0.0.1:6689` points to the worker itself. `vermeer-master` resolves to the master container on the shared Docker network in both examples. Keep `grpc_peer=0.0.0.0:6689` in `master.ini`, and mount this configuration directory at `/go/bin/config` in both containers. Publishing HTTP port `6688` alone does not configure the worker's gRPC connection. + 1. **Option 1: Docker Compose (Recommended)** Please ensure that `docker-compose.yaml` exists in your project root directory. If it doesn't, here is an example: ```yaml services: - vermeer-master: - image: hugegraph/vermeer - container_name: vermeer-master - volumes: - - ~/.config:/go/bin/config # Change here to your actual config path - command: --env=master - networks: - vermeer_network: - ipv4_address: 172.20.0.10 # Assign a static IP for the master - - vermeer-worker: - image: hugegraph/vermeer - container_name: vermeer-worker - volumes: - - ~/:/go/bin/config # Change here to your actual config path - command: --env=worker - networks: - vermeer_network: - ipv4_address: 172.20.0.11 # Assign a static IP for the worker + vermeer-master: + image: hugegraph/vermeer + container_name: vermeer-master + ports: + - "6688:6688" + volumes: + - ~/.config:/go/bin/config # Change here to your actual config path + command: --env=master + networks: + vermeer_network: + ipv4_address: 172.20.0.10 # Assign a static IP for the master + + vermeer-worker: + image: hugegraph/vermeer + container_name: vermeer-worker + volumes: + - ~/.config:/go/bin/config # Change here to your actual config path + command: --env=worker + networks: + vermeer_network: + ipv4_address: 172.20.0.11 # Assign a static IP for the worker networks: - vermeer_network: - driver: bridge - ipam: - config: - - subnet: 172.20.0.0/24 # Define the subnet for your network + vermeer_network: + driver: bridge + ipam: + config: + - subnet: 172.20.0.0/24 # Define the subnet for your network ``` Modify `docker-compose.yaml` -- **Volume**: For example, change both instances of `~/:/go/bin/config` to `/home/user/config:/go/bin/config` (or your own configuration directory). +- **Volume**: Change both instances of `~/.config:/go/bin/config` to `/home/user/config:/go/bin/config` (or the configuration directory prepared above). Review Comment: 🧹 This option tells readers to use the existing `docker-compose.yaml` if there is one, then to build and run `docker-compose up -d` in the Vermeer root. That directory already has `vermeer/docker-compose.yaml` (hugegraph-computer master 04985bb), and it is still the old file: `vermeer-master` has no `ports` entry, and both services mount `~/:/go/bin/config`. A reader who follows these steps with that file gets no host port 6688. The `curl` check and the Python client (whose page now says Docker deployments must publish `6688:6688`) then fail, and this bullet asks them to replace `~/.config:/go/bin/config`, which that file does not contain. Requested change: tell readers to add `ports: ["6688:6688"]` to `vermeer-master` and to set both volumes to the prepared config directory, whether they use the repository's `docker-compose.yaml` or the example above. Alternatively, update `vermeer/docker-compose.yaml` in hugegraph-computer to match. Please make the same change on the Chinese page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
