imbajin commented on PR #3146: URL: https://github.com/apache/hugegraph/pull/3146#issuecomment-5716470969
Completed six independent review lanes and pushed a small portability fix in c6cf10be65fe89ea05a1f9f950ce7e0322d38688: pin the golden corpus to LF in `.gitattributes`. With `core.autocrlf=true`, checkout previously converted it to CRLF and broke the byte-exact generator comparison; the fixed checkout now matches the committed corpus byte for byte. Java 11 validation passed: 19 focused tests and all 345 commons `UnitTestSuite` tests, with no failures or skips. The final three-line fix received an independent check. No production code or corpus content changed. Review score: **9.0/10**. No remaining actionable code findings within the six-operation contract; final-head CI is running, so approval is pending those results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
