imbajin commented on code in PR #3216: URL: https://github.com/apache/hugegraph/pull/3216#discussion_r4039139511
########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/core/GraphSpaceInfoLocaleTest.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.unit.core; + +import java.util.Locale; +import java.util.Map; + +import org.apache.hugegraph.space.GraphSpace; +import org.apache.hugegraph.testutil.Assert; +import org.apache.hugegraph.unit.BaseUnitTest; +import org.junit.Test; + +/** + * GraphSpace.info() formats the storage percentage and parses it back; + * that must not depend on the JVM's default locale (a decimal comma on + * pl_PL, de_DE, fr_FR, ... used to fail with NumberFormatException). + */ +public class GraphSpaceInfoLocaleTest extends BaseUnitTest { + + private static float storagePercent(Locale locale) { + Locale saved = Locale.getDefault(); + Locale.setDefault(locale); Review Comment: 🧹 Minor: `Locale.setDefault(locale)` changes both the FORMAT and DISPLAY defaults, but this test saves only `Locale.getDefault()` and restores with `Locale.setDefault(saved)`. On a JVM whose category defaults differ, the `finally` block restores the FORMAT/base locale to both categories, leaking the original DISPLAY locale to later tests in the same suite. Save and restore `Locale.getDefault(Locale.Category.FORMAT)` and `Locale.getDefault(Locale.Category.DISPLAY)` separately, or only change the FORMAT category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
