imbajin commented on code in PR #3157:
URL: https://github.com/apache/hugegraph/pull/3157#discussion_r4041001779
##########
hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/AbstractClient.java:
##########
@@ -98,79 +104,154 @@ public static <T extends AbstractStub> T setAsyncParams(T
stub, PDConfig config)
new Authentication(config.getUserName(),
config.getAuthority()));
}
- protected AbstractBlockingStub getBlockingStub() throws PDException {
+ protected synchronized AbstractBlockingStub getBlockingStub() throws
PDException {
Review Comment:
Rechecked the complete unary path against the base: resetStub() closes the
shared channel before discovery. On the base, the cached unary call then fails
and enters the same monitor in blockingUnaryCall() to retry, so the claimed
healthy independent unary path is absent. Two independent lanes withdrew this
finding after that comparison. No end-to-end latency regression has been
established; restoring an unlocked getter alone would not fix shared-transport
churn. Resolving this regression claim, while leaving transport separation as a
possible future design topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
