bitflicker64 commented on code in PR #493:
URL: https://github.com/apache/hugegraph-doc/pull/493#discussion_r4047799998
##########
i18n/en.yaml:
##########
@@ -4,3 +4,24 @@ ui_ask_ai_description: Powered by Kapa; only your question is
sent.
ui_ask_ai_latest: Answers use the latest documentation
ui_retry: Retry
ui_ai_error: AI is temporarily unavailable. Local search is unaffected.
+ui_more_versions: More versions
+download_release_version: Version
+download_release_date: Release Date
+download_release_notes: Release Notes
+download_table_component: Component
+download_table_type: Type
+download_table_mirror: Download (ASF mirror)
+download_type_binary: Binary
+download_type_source: Source
+download_component_server: Server
+download_component_toolchain: Toolchain
+download_component_ai: AI
+download_component_computer: Computer
+download_component_commons: Common
+download_asf_note: All packages on this page are official Apache Software
Foundation releases served from ASF mirrors, with signatures and checksums
hosted on downloads.apache.org. Source archives generated automatically by
GitHub are not ASF releases.
Review Comment:
⚠️ This note says every package on the page is an official ASF release, but
the tables also list the Server/Toolchain (and 1.0.0 Computer) binary tarballs.
Under ASF release policy only the source archive is the Apache release;
binaries are convenience builds. The site's own maturity page says the same
thing (`content/en/community/maturity.md`, RE40: "only the source code archive
is an official Apache release"), so the download page now contradicts it. The
Chinese string at `i18n/zh-CN.yaml:257` has the same wording.
Could the note say that the source archives are the official releases and
the binary packages are convenience builds, with both still served from ASF
mirrors and verifiable with the ASC/SHA512 files? For example: "Source archives
are the official Apache Software Foundation releases; binary packages are
convenience builds made from them. All files are served from ASF mirrors, with
signatures and checksums on downloads.apache.org. Source archives generated
automatically by GitHub are not ASF releases."
##########
layouts/_partials/community/members.html:
##########
@@ -0,0 +1,41 @@
+{{- $page := .page -}}
+{{- $data := hugo.Data.community.roster -}}
+{{- $labels := dict
+ "en" (dict "title" "Project members" "lead" "Current Apache HugeGraph PMC
members and Committers, sourced from public ASF records." "chair" "Chair" "pmc"
"PMC" "committers" "Committers")
+ "cn" (dict "title" "项目成员" "lead" "Apache HugeGraph 当前的 PMC 成员与
Committers，数据来自 ASF 公开记录。" "chair" "主席" "pmc" "PMC" "committers" "Committers")
+-}}
+{{- $copy := index $labels $page.Language.Lang | default (index $labels "en")
-}}
+{{- $style := resources.Get "scss/community-members.scss" | toCSS | minify |
fingerprint -}}
+<link rel="stylesheet" href="{{ $style.RelPermalink }}" integrity="{{
$style.Data.Integrity }}" crossorigin="anonymous">
+<section id="project-members" class="td-landing-section hg-community-members"
aria-labelledby="project-members-title">
+ <div class="td-site-container">
+ <div class="td-landing-section__header hg-community-members__header">
+ <h2 id="project-members-title">{{ $copy.title }}</h2>
+ <p>{{ $copy.lead }}</p>
+ </div>
+ {{- range $role := slice "pmc" "committers" }}
+ {{- $members := index $data.roles $role }}
+ <section class="hg-community-members__role" data-community-role="{{
$role }}" aria-labelledby="project-members-{{ $role }}">
+ <h3 id="project-members-{{ $role }}">{{ index $copy $role }}</h3>
+ <ul class="td-landing-contributor-grid hg-community-members__grid"
role="list">
+ {{- range $members }}
+ <li class="td-landing-contributor hg-community-member">
+ {{- $hasGithub := .github -}}
+ {{- if $hasGithub }}
+ <a class="hg-community-member__surface hg-community-member__link"
href="{{ .profile_url }}" target="_blank" rel="noopener noreferrer"
aria-label="{{ .name }} on GitHub">
Review Comment:
🧹 The accessible name is built as `{{ .name }} on GitHub` for every locale,
so on `/cn/community/` a screen reader announces "Cong Zhao on GitHub" while
the rest of the section is in Chinese. The partial already has a per-language
`$labels` dict a few lines up; could it carry the suffix too (for example
`"github" "on GitHub"` for `en` and `"github" "的 GitHub 主页"` for `cn`) and use
`{{ .name }} {{ $copy.github }}` here? The Chromium assertion on `"Cong Zhao on
GitHub"` only covers the EN page, so it would keep passing.
##########
content/en/docs/clients/restful-api/vertex.md:
##########
@@ -5,7 +5,7 @@ weight: 7
description: "Vertex REST API: Create, query, update, and delete vertex data
in the graph with support for batch operations and conditional filtering."
---
-### 2.1 Vertex
+## 2.1 Vertex {#vertex-api}
Review Comment:
🧹 Promoting `2.1 Vertex` to `##` fixes the page's first heading, but the
subsections stayed at `####` (`2.1.1 Create a vertex` through `2.1.8`), so the
outline now jumps from h2 straight to h4. Before this change it was h3 -> h4,
which was sequential. The CN page
(`content/cn/docs/clients/restful-api/vertex.md:8`) has the same jump. Could
the `2.1.x` headings move up to `###`, with the `#####` blocks under them
moving to `####`, so the heading order stays sequential in both languages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
