SebastianGruza commented on PR #771: URL: https://github.com/apache/hugegraph-toolchain/pull/771#issuecomment-5768219775
Round 1 in a57545f3: `BigDecimal` goes out as a plain JSON number instead of a string (numeric keys work against every server; DECIMAL gets every digit once the server reads fractions as BigDecimal, apache/hugegraph#3209 0146849b), the 128/128 bounds are applied in both `valueToDecimal` copies and in `BytesBuffer`, and the loader parses JSON without a detour through double and converts list elements one by one. Tests: client unit 78/78, loader unit 14/14, `DecimalPropertyApiTest` 6/6 and `testCreateWithBigDecimalOnDoubleKey` against a server built from 0146849b; checkstyle clean. The "public API" section of the description is updated: no behaviour change for existing types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
