AvanishShukla20 commented on issue #3236:
URL: https://github.com/apache/hugegraph/issues/3236#issuecomment-5826872078

   > The log4j2.xml files for PD, Store and Server all have LOG_PATH set to 
plain "logs", and the scripts cd into the install folder before starting Java, 
so would -l actually move where the logs get written, or just the folder the 
script checks? 
   
   Enabling log overrides through -l will move the folders where logs are 
written, so the both for the script and the log4j2 configuration file with 
plain “logs” would be replaced to let the user override the log directory and 
provide the directory referenced by LOGS_OVERRIDE
   
   > Store also writes its gc log to ./logs/gc.log
   
   The Store script's GC logging option is a literal relative path 
./logs/gc.log,  embedded when JAVA_OPTIONS is unset . We can set the 
JAVA_OPTIONS environment variable before invoking the startup scripts — then 
this bypasses that block (including GC logging). So you'd need to supply your 
own -Xlog:gc=...:file=<path> argument yourself [gc log 
reference](https://github.com/apache/hugegraph/blob/4f5202b8::master/hugegraph-store/hg-store-dist/src/assembly/static/bin/start-hugegraph-store.sh#L30-L38)
   
   > The pid file goes into bin/pid too, and the stop scripts read it from 
there, so on a read-only install that write would fail, and two instances from 
the same install would end up sharing it. Are you planning to cover the stop 
scripts and the pid file as well?
   
   Thanks for pointing this, I have addressed this and i think we should 
provide flags to override the $BIN/pid file as well.
   
   >  Also rest-server.properties has graphs=./conf/graphs, which resolves 
against the install folder, so I'm guessing that would need to follow -c as well
   
   We can set the graphs directory to either relative or absolute in 
rest-server.properties . 
   Eg:
   In rest-server.properties we can use 
   graphs=<GRAPHS_DIR> 
   In gremlin-server.yaml , similarly 
   graphs: {
                hugegraph: <GRAPH_DIR>/hugegraph.properties
   }
   
   > And since PD, Store and Server already ship as separate folders with their 
own conf and logs, is the main case running more than one instance of the same 
role from one install?
   
   Yes, that is one of the reasons and there are other ones also that can be 
found in the proposal
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to