bitflicker64 commented on code in PR #502:
URL: https://github.com/apache/hugegraph-doc/pull/502#discussion_r4121201850
##########
content/en/docs/config/config-option.md:
##########
@@ -80,18 +79,6 @@ Corresponding configuration file `rest-server.properties`
| log.slow_query_threshold | 1000
| The threshold time(ms) of logging slow query, 0 means logging
slow query is disabled.
|
| log.slow_query_body_limit | 512
| The max bytes of request body recorded in the slow query log, 0
means the body is not recorded. The recorded prefix is written as-is and may
contain sensitive Gremlin or Cypher literals. |
-> [!DETAILS]- **Role Election Config Options (Optional)**
Review Comment:
Minor: These options still work in the current release, so deleting them
outright drops the only reference for 1.7.0 users. At the `1.7.0` tag,
`GraphManager.serverStarted()` calls `initRoleStateMachine()` when
`server.role_election=true`, and `RoleElectionOptions` reads all six
`server.role.*` keys. On apache/hugegraph master (2f827d6e8) the options still
parse, but `initNodeRole()` only logs a deprecation warning and
`serverStarted()` skips the state machine, which matches the PR description.
The options only disappear with apache/hugegraph#3244, which is still open
(head 5117958, review required). This page already describes version-specific
options, for example the backend row at line 113 ("removed in 1.7.0 (use <=
1.5.x for legacy backends)") and the section headed "no longer supported in
version 1.7.0+".
Requested change: keep a short note in place of the block in both en and cn
pages, for example "`server.role_election` and `server.role.*` apply to 1.7.0
and earlier. They have no effect on later versions, and a server that still
sets them ignores them." Also hold the merge until apache/hugegraph#3244 is
merged, since the PR description ties the two together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
