bitflicker64 commented on code in PR #506:
URL: https://github.com/apache/hugegraph-doc/pull/506#discussion_r4156708330
##########
content/en/docs/quickstart/client/hugegraph-client.md:
##########
@@ -41,12 +41,21 @@ Using IDEA or Eclipse to create the project:
<dependency>
<groupId>org.apache.hugegraph</groupId>
<artifactId>hugegraph-client</artifactId>
- <!-- Select a released version from the download page -->
- <version>1.7.0</version>
+ <!-- Matches the Toolchain master used in this guide -->
+ <version>1.8.0</version>
Review Comment:
Minor: The quickstart POM now uses `hugegraph-client` 1.8.0, which is not on
Maven Central, so a reader who copies this snippet gets a dependency resolution
failure unless they first build Toolchain from source.
Evidence:
`https://repo1.maven.org/maven2/org/apache/hugegraph/hugegraph-client/maven-metadata.xml`
lists 1.0.0 through 1.7.0, with 1.7.0 as the newest. The example in 4.3 only
calls `schema()`, `graph()`, `gremlin()` and `close()`, which 1.7.0 already
provides, so the text below ("older clients may not provide the APIs used in
this guide") does not apply to this quickstart. Before this PR the snippet
resolved as-is with 1.7.0.
Requested change: keep the published 1.7.0 as the copy-paste default and
present 1.8.0 plus the `mvn install -pl hugegraph-client -am` step as the
option for master-only APIs, or state plainly that 1.8.0 must be built locally.
Apply the same change to the Chinese page
(`content/cn/docs/quickstart/client/hugegraph-client.md`, line 48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
