imbajin commented on code in PR #3117:
URL: https://github.com/apache/hugegraph/pull/3117#discussion_r4158809287
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/ContextGremlinServer.java:
##########
@@ -158,6 +204,14 @@ private void removeGraph(String name) {
}
static ExecutorService newGremlinExecutorService(Settings settings) {
+ if (!HugeGraphWsAndHttpChannelizer.class.getName().equals(
Review Comment:
🟡 [P2] Ship the mounted-config and Gremlin-client migration guide
This mandatory channelizer check rejects a retained 1.7 gremlin-server.yaml
using the upstream WsAndHttpChannelizer. GremlinLangRequestGuard also restricts
remote text requests to gremlin-lang, so replacing only the packaged defaults
leaves mounted configs and existing gremlin-groovy clients without upgrade
instructions. README/BUILDING describe Java 17 but no corresponding Gremlin
migration guide or paired website PR is supplied. Please document the required
channelizer/engine/serializer names, accepted text and Bytecode request forms,
and compatible Client versions; align the stated TinkerPop target with the
3.8.1 POMs. This is a static current-source contract check, not proof that the
whole upgraded stack runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
