byteayan commented on PR #3246: URL: https://github.com/apache/hugegraph/pull/3246#issuecomment-5937704861
Thanks for the review. On `codecov/project` at 456cb36 (41.55%, -0.02% vs 82034fb): the drop doesn't come from this change. Per Codecov's compare data, the code this PR deletes or edits (RedirectFilter, RedirectFilterDynamicFeature, the election state in GlobalMasterInfo, ApplicationConfig, GraphTransaction.queryServerInfos) removes 92 lines and 30 hits, which on its own would put coverage at 41.59% (+0.01%). The difference is 21 fewer hits in files this PR doesn't touch, mostly timing-dependent PD/Store/HStore code (DistributedTaskScheduler -7, store PartitionManager -6, PdMetaDriver -3, TaskMetaManager -2, several -1s, +2 in TaskScheduleService), so it is run-to-run variation rather than lost coverage. Patch coverage is 100% (`codecov/patch` passes), and `codecov/project` is not among the required checks in `.asf.yaml`. If you'd like the check green before merging, re-running the hstore/pd/store jobs may settle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
