contrueCT opened a new pull request, #3262: URL: https://github.com/apache/hugegraph/pull/3262
## Purpose of the PR Part 2 of a three-PR upgrade series targeting `apache/hugegraph:master`. Preserve transaction count and predicate semantics while retaining TinkerPop 3.5.1. Merge order: [apache#3261](https://github.com/apache/hugegraph/pull/3261) (Java 17 foundation) → the corresponding ASF PR for [community #232](https://github.com/hugegraph/hugegraph/pull/232) (query semantics) → the corresponding ASF PR for [community #233](https://github.com/hugegraph/hugegraph/pull/233) (TinkerPop upgrade). All three PRs target `master` directly. Merge this PR after [apache#3261](https://github.com/apache/hugegraph/pull/3261). Until the prerequisite is merged, the Files changed tab includes its changes; the part-2-only diff is available in [community #232](https://github.com/hugegraph/hugegraph/pull/232/files). Source: [hugegraph/hugegraph#232](https://github.com/hugegraph/hugegraph/pull/232), submitted directly from `hugegraph:task/tp381-2-query-semantics`. The local validation statements below are carried over from that source PR; CI on this ASF PR head remains the merge gate. ## Main Changes - Count uncommitted vertex/edge changes through the transaction query path and always close fallback iterators. Continue rejecting limit, offset, paging and unsupported aggregates with uncommitted changes. - Retain unsupported text predicates as traversal filters while extracting supported label/index conditions. Count optimization does not skip filtering barriers. - Reset optimized count execution state and exclude result iterators from query-step equality. This fixes the existing count equality regression. TinkerPop-specific `NotP`, serializer and step-API changes remain in part 3. This PR still compiles and runs against TinkerPop 3.5.1. ## Verifying these changes - [x] Already covered by existing tests: `CountStrategyCoreTest`, `TraversalUtilOptimizeTest`, `GraphTransactionTest`, and `QueryListTest`. - Local validation: Formatting and all-module clean compile passed. 90 targeted tests passed in isolated JUnit JVMs against TinkerPop 3.5.1. ## Does this PR potentially affect the following parts? - [ ] Dependencies - [ ] Modify configurations - [x] The public API - [x] Other affects: transaction count and traversal optimization behavior - [ ] Nope ## Documentation Status - [ ] `Doc - TODO` - [x] `Doc - Done` - [ ] `Doc - No Need` Documentation: `docs/query-semantics.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
