bitflicker64 commented on code in PR #3260:
URL: https://github.com/apache/hugegraph/pull/3260#discussion_r4174925741
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java:
##########
@@ -159,6 +159,10 @@ private void invalidateUserCache() {
}
private void invalidatePasswordCache(Id id) {
+ // TODO: invalidate the password and token caches on every Server
replica, not only on the
Review Comment:
Important: This TODO describes the shared PD catalog case, but that
deployment does not run this class.
`StandardHugeGraph` (around line 281 at this head) builds `new
StandardAuthManagerV2(this.params)` when `isHstore()` and `StandardAuthManager`
only otherwise. The Helm chart's Server uses the hstore backend, so its
password and token caches live in `StandardAuthManagerV2`, which has its own
`pwdCache`, `tokenCache` and a separate `invalidatePasswordCache(Id)` (around
line 254). Someone who follows this breadcrumb and fixes `StandardAuthManager`
leaves the chart's admin password rotation limitation unchanged, and nothing at
the V2 site tells them about it.
Requested change: put this TODO on
`StandardAuthManagerV2.invalidatePasswordCache`. If you also want to keep it
here, reword it for the non-PD case (several Servers sharing one backend such
as HBase) so it does not claim the PD catalog path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
