imbajin opened a new pull request, #778: URL: https://github.com/apache/hugegraph-toolchain/pull/778
## Purpose of the PR Loader test tooling needs JVM compatibility preparation, and cleanup can leave its distinct clients open when failure-log or progress handling throws. Close both clients while preserving the primary exception, suppressed failures and input-progress semantics. Original preparation and review: https://github.com/hugegraph/hugegraph-toolchain/pull/43. Depends on https://github.com/apache/hugegraph-toolchain/pull/775. Merge the shared build preparation first. This PR targets master and currently includes prerequisite changes; after the prerequisite lands, rebase this same organization branch onto the updated upstream base and revalidate the module diff before merging. ## Main Changes - Inherit shared coverage tooling and include existing unit tests in the suite. - Close both distinct clients on logger/progress failures without saving progress after a logger failure or repeating close side effects. - Preserve test profile selection and add the scoped JVM opening required by Hive ORC. - Honor JAVA_HOME in launcher/converter paths and quote the selected Java executable; source/target remain Java 8. ## Verifying these changes - [ ] Trivial rework / code cleanup without any test coverage. - [x] Already covered by Loader unit tests and launcher checks. - [x] Need tests and can be verified as follows: - Preparation suites and profile models were validated on JDK 11 and 17. - Latest logger/progress failure, suppressed-error and idempotence regressions passed on native Java 17. - Previous file-profile validation covers ORC, Parquet, authentication and HTTPS; current-head CI is still running/queued. ## Does this PR potentially affect the following parts? - [ ] Nope - [x] Dependencies (build/test tooling only; runtime payload is unchanged by this preparation) - [x] Modify configurations (CI/test configuration) - [ ] The public API (compatible behavior; signatures unchanged) - [x] Other affects: tests and validation tooling ## Documentation Status - [ ] Doc - TODO - [x] Doc - Done - [ ] Doc - No Need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
