AvanishShukla20 commented on code in PR #3253: URL: https://github.com/apache/hugegraph/pull/3253#discussion_r4181582401
########## hugegraph-server/hugegraph-dist/src/assembly/static/bin/start-monitor.sh: ########## @@ -37,6 +37,21 @@ fi # Monitor HugeGraphServer every minute, if the server crashes then restart it. # Modify the frequency according to actual needs carefully. -CRONTAB_JOB="*/1 * * * * export JAVA_HOME=$JAVA_HOME && $TOP/bin/monitor-hugegraph.sh" + +# Persist any path overrides (-c/-l/-i/-o) that the caller (start-hugegraph.sh) exported +CRONTAB_JOB="*/1 * * * * export JAVA_HOME=$JAVA_HOME &&" +if [ -n "$CONF_OVERRIDE" ]; then + CRONTAB_JOB="$CRONTAB_JOB export CONF_OVERRIDE='$CONF_OVERRIDE' &&" Review Comment: I have noted this concern and will address this in the next commit . I would like taking suggestion from the community which plan we should go for, is shell-escaping better or should we use the reject unsupported characters method . I thought to use the shell-escaping method so that this accepts legitimate but "unusual" paths instead of breaking workflows. So some paths passed like `/data/team's-logs` can now be interpreted as `/data/team\'s-logs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
