kalayciburak commented on code in PR #3291:
URL: https://github.com/apache/hugegraph/pull/3291#discussion_r4220193660
##########
hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/util/IpUtil.java:
##########
@@ -47,7 +47,9 @@ private static List<String> getIpAddress() throws
SocketException {
Enumeration addresses = network.getInetAddresses();
while (addresses.hasMoreElements()) {
InetAddress address = (InetAddress) addresses.nextElement();
- if (address != null && (address instanceof Inet4Address)) {
+ if (address instanceof Inet4Address &&
+ !address.isLoopbackAddress() &&
Review Comment:
yes, 127.0.0.1 stays when it is bound locally. loopback only drops out of
the fallback list now. added a test for that, and the 127.0.0.2 case assumes a
non-loopback ipv4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
