bitflicker64 commented on code in PR #3295:
URL: https://github.com/apache/hugegraph/pull/3295#discussion_r4227375214
##########
hugegraph-struct/pom.xml:
##########
@@ -138,6 +138,8 @@
<groupId>org.apdplat</groupId>
<artifactId>word</artifactId>
<version>1.3</version>
+ <!-- External optional analyzer; compile/test it without shipping
it. -->
+ <scope>provided</scope>
Review Comment:
Minor: With word in provided scope, this PR removes commons-pool2-2.0,
jedis-2.5.1, lucene-backward-codecs-5.2.1, lucene-misc-5.2.1,
lucene-suggest-5.2.1 and pinyin4j-2.5.0 from known-dependencies.txt, so the
binary package no longer ships them. install-dist/release-docs/LICENSE still
lists all six (lines 695, 697, 698, 702, 714 and 769), and
install-dist/release-docs/licenses/ still holds LICENSE-commons-pool2-2.0.txt,
LICENSE-jedis-2.5.1.txt,
LICENSE-lucene-{backward-codecs,misc,suggest}-5.2.1.txt and
LICENSE-pinyin4j-2.5.0.txt. That makes the release LICENSE disagree with the
bundled jars, which release verification checks. Please remove those six
LICENSE entries and their license text files in this PR, so the inventory and
LICENSE change together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
