contrueCT opened a new pull request, #3299: URL: https://github.com/apache/hugegraph/pull/3299
## Purpose of the PR Topling's standalone OLAP property clear still drops and recreates the same column family. The previously reported real-JNI reproduction completes the clear task, then aborts during normal shutdown. This change clears the selected table while retaining its CF handle. Addresses the OLAP clear/close item already tracked in #3242 and [the original review](https://github.com/hugegraph/hugegraph/pull/266#discussion_r4214095995). The release checklist stays open. Existing Topling and recovery PRs were checked; the merged runtime integration and current #3293 do not cover this clear path. ## Main Changes - Clear the selected OLAP table in its owning database under the store write lock. - Retain Topling CF handles and discard the clearing thread's pending batch before committing the clear; leave other threads' leases untouched. - Preserve the standard RocksDB drop/create path. ## Verifying these changes - [ ] Trivial rework / code cleanup without any test coverage. (No Need) - [x] `RocksDBSessionsTest`: 22 tests pass on Java 17, with no failures/errors/skips. New tests cover retained handle identity, repeated clears, pending writes outside the stored range and in an empty table, independent OLAP routing, other-table preservation, reuse and close/reopen reads. - [x] Affected Server reactor clean compilation, editorconfig formatting and `git diff --check` pass. These tests run the Topling Java branch with the real standard RocksDB JNI. The same handle-preservation regression fails against the original master adapter. Actual Topling JNI and its reported shutdown abort were not rerun on this macOS arm64 host; current-head Linux native qualification remains necessary. ## Does this PR potentially affect the following parts? - [ ] Dependencies - [ ] Modify configurations - [ ] The public API - [x] Other affects: standalone Topling OLAP clear and native handle lifecycle - [ ] Nope ## Documentation Status - [ ] `Doc - TODO` - [x] `Doc - Done`: `docs/toplingdb.md` documents OLAP clear, handle retention and pending-write handling. - [ ] `Doc - No Need` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
