imbajin opened a new pull request, #800: URL: https://github.com/apache/hugegraph-toolchain/pull/800
## Purpose of the PR The ordinary Loader launcher splits installation paths and user arguments containing spaces, expands literal globs, and drops empty arguments. The Java process now receives the intended classpath and original argument boundaries. Reported during [master integration testing](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763).  ## Main Changes - Quote installation and library paths, and pass the classpath as one Java argument. - Forward user arguments with `"$@"` while preserving existing JVM option handling and classpath order. - Run ordinary launcher argument regressions alongside the Spark launcher checks in Loader CI. ## Verifying these changes - [ ] Trivial rework / code cleanup without any test coverage. (No Need) - [ ] Already covered by existing tests. - [x] Need tests and can be verified as follows: - `python3 hugegraph-loader/src/test/python/test_loader_launcher.py` and the existing Spark launcher tests pass. - The original script fails argument regressions; a Java 17 entry point confirms spaces, empty arguments, and literal globs under both Bash and POSIX sh. - Packaged Loader import and PR CI remain to be verified. ## Does this PR potentially affect the following parts? - [ ] Nope - [ ] Dependencies (add/update license info) - [ ] Modify configurations - [ ] The public API - [x] Other affects: ordinary Loader process arguments ## Documentation Status - [ ] `Doc - TODO` - [ ] `Doc - Done` - [x] `Doc - No Need` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
