imbajin opened a new pull request, #802:
URL: https://github.com/apache/hugegraph-toolchain/pull/802

   ## Purpose of the PR
   
   Restore native JDBC DATETIME and Parquet logical date/timestamp conversion. 
MySQL returns LocalDateTime for DATETIME, while Parquet DATE/TIMESTAMP values 
were treated as ordinary integers; supported DATE mappings failed or produced 
incorrect dates.
   
   Found in the [Toolchain integration 
report](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763).
   
   
   ![loader dates: before and 
after](https://raw.githubusercontent.com/hugegraph/hugegraph-toolchain/7e0ff90eb82cf22597b40f0f97f7278ac55e5bdd/images/loader-dates.png)
   
   ## Main Changes
   
   - Let the JDBC driver convert LocalDateTime through 
ResultSet.getTimestamp(), preserving its timezone and precision.
   - Decode Parquet DATE and TIMESTAMP logical annotations with their declared 
units and UTC/local meaning.
   - Preserve TIME, unannotated integers, null and existing INT96 behavior; add 
native MySQL and real Parquet file regressions.
   
   
   ## Verifying these changes
   
   - [ ] Trivial rework / code cleanup without any test coverage. (No Need)
   - [ ] Already covered by existing tests.
   - [x] Need tests and can be verified as follows:
     - Real Parquet writer/file/reader tests and a JDBC driver-value regression 
fail against the old implementations and pass after the fix, including negative 
timestamps and preserved unrelated types.
     - Three independent read-only reviews passed.
     - Organization core CI passes, including the native MySQL DATETIME 
functional test. The final combined distribution builds against a fixed Server 
SDK; packaged consumer acceptance remains in progress.
   
   ## Does this PR potentially affect the following parts?
   
   - [x] Nope
   - [ ] Dependencies
   - [ ] Modify configurations
   - [ ] The public API
   - [ ] Other affects
   
   ## Documentation Status
   
   - [ ] `Doc - TODO`
   - [ ] `Doc - Done`
   - [x] `Doc - No Need`: corrects existing DATE mappings without adding types 
or configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to