imbajin opened a new pull request, #3305: URL: https://github.com/apache/hugegraph/pull/3305
## Purpose of the PR Fix two small existing behavior defects found in the [Toolchain integration report](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763): Project metadata saved as JSON failed on readback because its graph list was cast to Set, and PD/Store rejected the documented explicit `-g g1` argument.  ## Main Changes - Convert Project graph collections to a validated string set, preserving null/default behavior and duplicate handling. - Accept explicit g1/G1 through the existing default GC branch, retaining ZGC and invalid-argument behavior. - Add Project metadata roundtrip/CRUD regressions and GC argument coverage in the existing startup tests; update the launcher READMEs. These small integration fixes are grouped under the authorized batch scope; no unrelated cleanup or new API is included. ## Verifying these changes - [ ] Trivial rework / code cleanup without any test coverage. (No Need) - [ ] Already covered by existing tests. - [x] Need tests and can be verified as follows: - Actual JSON-to-Map-to-Project and AuthMetaManager CRUD tests pass after reproducing the original ClassCastException. - Both real launchers select the intended collector on Java 17 for default/G1/ZGC, and reject invalid values; shell syntax checks pass. - Three independent read-only reviews passed. - Authenticated Project CRUD and graph association roundtrips pass against a real disposable HStore Server. Complete PD/Store distribution validation for the latest launcher change remains in progress. ## Does this PR potentially affect the following parts? - [ ] Dependencies - [ ] Modify configurations - [ ] The public API - [x] Other affects: fixes documented launcher arguments and Project JSON readback. - [ ] Nope ## Documentation Status - [ ] `Doc - TODO` - [x] `Doc - Done` - [ ] `Doc - No Need` Documentation files in this PR or paired hugegraph-doc PR: - `hugegraph-pd/README.md` and `hugegraph-store/README.md`. Explicit `-g g1/G1` now selects G1 even on a small, single-CPU JVM; omitting `-g` preserves the caller's collector selection. Real Java probes verify the collector choice, and contradictory collector options retain the JVM's clear failure behavior. Packaged service validation remains pending for this follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
