bitflicker64 commented on code in PR #518:
URL: https://github.com/apache/hugegraph-doc/pull/518#discussion_r4245451903
##########
content/en/docs/quickstart/toolchain/hugegraph-loader.md:
##########
@@ -874,7 +895,7 @@ Recorded in the progress file, the progress file is located
in the `${struct}` d
moment, formatted as `yyyyMMdd-HHmmss`. For example, for an import task
started at `2019-10-10 12:30:30`, the mapping file used is
`struct-example.json`, then the path of the progress file is the same as
struct-example.json
Sibling `struct-example/load-progress_20191010-123030`. When the directory
holds several progress files, the resumed import reads the last one in name
order, which is the most recent one.
-> Note: The generation of progress files is independent of whether
--incremental-mode is turned on or not, and a progress file is generated at the
end of each import.
+> Note: Progress files are generated after every import, regardless of
`--incremental-mode` or `--print-progress`.
Review Comment:
Minor: "generated after every import" no longer matches Toolchain `master`,
which this guide says it follows. Since apache/hugegraph-toolchain#801,
`LoadContext.close()` calls `throwIfFailed()` before `newProgress.write(this)`,
so an import that ended through `failLoading(...)` (a parse or insert task
threw, or the task manager was interrupted or cancelled) throws `Loading failed
without recoverable progress` and writes no `load-progress_<timestamp>` file.
In 1.7.0 the write was unconditional, which is what the old sentence described.
The `--print-progress` part of the new wording is correct: that flag is only
read in `Printer`.
Since this PR rewrites the sentence, please scope it, for example: "A
progress file is written when an import finishes or is stopped normally
(including by an error limit), regardless of `--incremental-mode` or
`--print-progress`; an import that aborts on an unexpected failure writes
none." The Chinese note on line 898 of
`content/cn/docs/quickstart/toolchain/hugegraph-loader.md` needs the same
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
