imbajin commented on code in PR #3309:
URL: https://github.com/apache/hugegraph/pull/3309#discussion_r4253616863
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/UnitTestSuite.java:
##########
@@ -247,13 +252,19 @@
RocksDBSessionTest.class,
RocksDBCountersTest.class,
RocksDBTableQueryByIdsTest.class,
+ RocksDBStdSessionsLifecycleTest.class,
+ RocksDBIteratorPoolTest.class,
+
+ /* memory */
+ MemoryManageTest.class,
/* utils */
ConsumersTest.class,
VersionTest.class,
JsonUtilTest.class,
StringEncodingTest.class,
CompressUtilTest.class,
+ ConsumersTest.class,
Review Comment:
[P3] Avoid registering ConsumersTest twice
ConsumersTest is already present at line262, inherited from the current
base; this added entry registers it a second time. JUnit Suite creates a runner
for each class-array entry without deduplicating. The class has12 active @Test
methods, so this schedules24 executions for12 unique cases, adding runtime and
inflating the suite total without adding coverage. Please remove this second
entry and keep the existing registration. This persists in the current PR but
is not introduced by the latest two-file map-fixture commit. Source:
https://junit.org/junit4/xref/org/junit/runners/model/RunnerBuilder.html#98 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
