imbajin commented on code in PR #3325: URL: https://github.com/apache/hugegraph/pull/3325#discussion_r4254200865
########## docs/server-runtime.md: ########## @@ -28,6 +28,32 @@ uses G1 with an occupancy threshold of 45 when `JAVA_OPTIONS` is empty. Do not combine explicit `-g` selection with a different collector in `JAVA_OPTIONS` or `-j`; the JVM rejects conflicting collector selections. +### Launcher memory budget + +The default launcher heap uses half the smaller of host available memory and the +remaining budget under visible cgroup v1/v2 hard limits, with a 512 MiB minimum and a +32 GiB maximum. It refuses startup when the effective budget is below 512 MiB. +If a known hard limit has missing, unreadable or invalid usage, the budget is zero; +the launcher refuses startup instead of using host memory. Cgroup v1 numeric unlimited +levels are skipped so readable finite ancestors still apply; without a finite limit, +host sizing remains available. The sentinel uses the native long and page sizes. Review Comment: Fresh source-delta review: 9/10 for a2888b5 → e1613fe. The kernel-machine-width correction addresses the finite-limit misclassification; no new source blocker found. Nonblocking P3: docs/server-runtime.md:37–39 still describes native-long detection and unconditional numeric-unlimited skipping. Please describe the recognized x86_64/aarch64/riscv64 plus PAGESIZE rule, and qualify unlimited skipping as recognized; unknown/masked names retain numeric-limit handling. Explicit independent 4/16/64-KiB boundary fixtures would strengthen coverage. These are source-review conclusions, not newly executed compatibility tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
