imbajin commented on code in PR #3328: URL: https://github.com/apache/hugegraph/pull/3328#discussion_r4254200055
########## .gitattributes: ########## @@ -15,5 +15,8 @@ install-dist/scripts/ export-ignore hugegraph-commons/hugegraph-dist/ export-ignore docker/ export-ignore +# Documentation images are not needed in source releases. +/docs/images/ export-ignore Review Comment: Source review: 8.5/10 for this head; no confirmed build/runtime blocker. P3: the source archive now excludes docs/images, but docs/storage-lifecycle.md:421 still embeds images/switch-rocksdb-to-toplingdb.png. The retained guide therefore renders a broken illustration when opened from an extracted source release. Please update this consumer to an external image URL consistently with the Helm README, or retain its target. This is a source-derived documentation issue; I did not build or execute the archive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
