imbajin commented on code in PR #525:
URL: https://github.com/apache/hugegraph-doc/pull/525#discussion_r4254688612
##########
content/en/docs/quickstart/toolchain/hugegraph-loader.md:
##########
@@ -986,6 +990,29 @@ bin/hugegraph-loader.sh \
Expected result: two vertices and zero edges imported. This example uses
dedicated schema names to avoid conflicts with a preloaded `person` label. In
Hubble, run `g.V().hasLabel('docs_smoke_person').values('docs_name')` to
confirm `docs-smoke-alice` and `docs-smoke-bob`.
+#### 3.4.6 Concurrent imports and LOADING ownership {#loading-ownership}
+
+Upgrade both Server and Client/Loader to builds containing `/mode/owners`
protocol 1; a version number or Docker `latest` tag alone does not confirm
support.
+Server 1.7 recognizes `LOADING` but has no ownership endpoint. Normal imports
fail if the capability is absent or invalid, without falling back to enum
+mode PUT or `NONE`. This check precedes `--clear-all-data`, Schema creation
and import-data writes; `--create-graph` can create the target graph first.
Review Comment:
P2: Label the owner-aware Loader as proposed/unreleased until the matching
client is available. This guide says it follows Toolchain master and directs
readers to build Apache master, but current master41e8d711 and the proposed#814
LoadContext still use enum LOADING/NONE plus a per-context boolean; neither
performs the capability probe or owner-handle lifecycle described here.
Following these commands therefore does not obtain the promised
fail-closed/concurrent-owner protection. Please qualify both EN/ZH sections,
explicitly state that current master/download instructions lack these
guarantees, and link/pin the paired Client/Loader and Server refs when
available. Server#3331 alone is insufficient. This is a source-confirmed
build/documentation mismatch; no new runtime test was executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
