imbajin opened a new pull request, #3335:
URL: https://github.com/apache/hugegraph/pull/3335

   ## Purpose of the PR
   
   VPN and tunnel interfaces can have an IP address without a hardware address. 
Previously MAC discovery threw a `NullPointerException` and left an empty 
cache, hiding usable interfaces on the next call.
   
   ## Main Changes
   
   - Skip unavailable hardware addresses when collecting MACs, while keeping 
direct lookups as explicit failures.
   - Publish the MAC cache only after the complete collection succeeds, so 
lookup errors remain retryable.
   
   Normal MAC encoding, IP enumeration, public signatures and PD IP/MAC 
identity selection remain unchanged.
   
   ## Verifying these changes
   
   - [ ] Trivial rework / code cleanup without any test coverage. (No Need)
   - [ ] Already covered by existing tests.
   - [x] Need tests and can be verified as follows:
   
   Added real-JDK loopback, mixed-interface, deduplication and retry 
regressions. Commons and RPC consumer suites, full reactor compilation, 
formatting and a redacted real-interface before/after control pass.
   
   ## Does this PR potentially affect the following parts?
   
   - [ ] Dependencies
   - [ ] Modify configurations
   - [ ] The public API
   - [ ] Other affects
   - [x] Nope
   
   ## Documentation Status
   
   - [ ] `Doc - TODO`: required documentation is pending; complete it before 
merging.
   - [ ] `Doc - Done`: documentation is included here or linked below.
   - [x] `Doc - No Need`: this is an internal helper correction with no new 
configuration or website behavior.
   
   PD REST identity-pairing acceptance remains a separate follow-up.
   
   
   <!-- This is an auto-generated comment: release notes by coderabbit.ai -->
   
   ## Summary by CodeRabbit
   
   * **Bug 修复**
     * 改进 MAC 地址获取的稳定性:遇到网卡未提供硬件地址、地址重复或查询失败时,不再因空值引发意外异常。
     * 无可用 MAC 地址时返回空结果;地址查询失败后再次调用可重新尝试获取。
   
   <!-- end of auto-generated comment: release notes by coderabbit.ai -->
   
   Paired org PR: https://github.com/hugegraph/hugegraph/pull/307
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to