imbajin opened a new pull request, #817:
URL: https://github.com/apache/hugegraph-toolchain/pull/817
## Purpose of the PR
The first `updatingStrategy(property, strategy)` call on either batch
request builder throws a NullPointerException unless the caller has already
used the plural setter.
## Main Changes
Initialize the strategy map on the first singular call. Repeated calls still
accumulate entries and replace the same key; the plural setter still
defensively copies and replaces the whole map. Builders without strategies keep
their existing null default.
## Verifying these changes
- [x] Need tests and can be verified as follows:
- Vertex/edge regressions reproduce the original NPE and pass after the
fix.
- Existing accumulation, overwrite, replacement and defensive-copy
behavior is covered.
- Complete Client unit suite, Java 17 compilation, formatting, Checkstyle
and diff checks pass.
- Three independent reviewers found no blocking issue.
## Does this PR potentially affect the following parts?
- [ ] Dependencies
- [ ] Modify configurations
- [x] The public API
- [ ] Other affects
- [ ] Nope
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`: restores the existing fluent setter contract; no new
API or configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
