arshilkxwork commented on code in PR #3334:
URL: https://github.com/apache/hugegraph/pull/3334#discussion_r4266353636
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -1877,13 +1878,15 @@ private void checkBackendVersionOrExit(HugeConfig
config) {
if (!hugegraph.backendStoreFeatures().supportsPersistence()) {
hugegraph.initBackend();
if (this.requireAuthentication()) {
- String adminPassword = config.get(ServerOptions.ADMIN_PA);
+ // Outside the try so a bad password file names itself
+ String adminPassword =
+ StandardAuthenticator.initialAdminPassword(config);
Review Comment:
Fixed in f7f38ac. `checkBackendVersionOrExit` now skips the password lookup
and `initAdminUser` when `StandardAuthenticator` runs with `auth.remote_url`,
the same case `shouldBootstrapAdmin` excludes on the PD path. Custom
authenticators still get `initAdminUser` as before.
`testNonPersistentBackendWithRemoteAuthSkipsAdminPasswordFile` covers remote
auth with a missing file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
