imbajin commented on code in PR #372: URL: https://github.com/apache/hugegraph-ai/pull/372#discussion_r4273917543
########## hugegraph-llm/src/hugegraph_llm/extraction_runtime/v1/contracts.py: ########## @@ -0,0 +1,60 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# http://www.apache.org/licenses/LICENSE-2.0 +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +"""Inputs and per-chunk results for reviewed extraction.""" + +from dataclasses import asdict, dataclass, field +from typing import Literal + +from pydantic import BaseModel, Field + + +class ExtractionOptions(BaseModel): Review Comment: ⚠️ `ExtractionOptions` leaves Pydantic's default extra handling in place, so `{"max_review": 0}` is accepted and `max_reviews` remains 2. Because providing this object enables billable review/repair calls, a typo can invoke work the caller believed disabled; set `extra="forbid"` and cover the API response for an unknown key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
