imbajin opened a new pull request, #819:
URL: https://github.com/apache/hugegraph-toolchain/pull/819

   ## Purpose of the PR
   
   A CDC command ending with `--password` or `--file` could invoke Flink before 
Loader reported the missing value. The launcher now rejects that trailing 
missing value before invoking Flink, using the existing Loader argument grammar 
and preserving the original Flink/Loader argument boundaries.
   
   Follow-up to [the CDC launcher 
review](https://github.com/hugegraph/hugegraph-toolchain/pull/47#discussion_r4226046257).
 The Flink CDC guide documents the rejection behavior.
   
   ## Verifying these changes
   
   The launcher regression reproduces the previous invocation and now verifies 
that Flink is never called for a trailing missing value. Existing 
argument-boundary, credential-output and ordinary Loader checks, ShellCheck and 
shell syntax checks passed. Independent reviews found no blocking issue.
   
   ## Does this PR potentially affect the following parts?
   
   - [x] Other affects: CDC launcher validation before submission.
   
   ## Documentation Status
   
   - [x] `Doc - Done`
   
   Organization counterpart: 
https://github.com/hugegraph/hugegraph-toolchain/pull/72.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to