imbajin commented on PR #3347: URL: https://github.com/apache/hugegraph/pull/3347#issuecomment-6176504979
[P2] Final distributed close can lose its cancellation executor If a busy cron operation makes both early graph-close attempts time out while a schema/OLAP task is still active, the final close still needs to cancel that task. However, TaskManager.close() has already terminated distributedSchedulerExecutor. DistributedTaskScheduler.close() passes the terminated barrier, then cancelOwned() submits cancellation back to that executor and gets RejectedExecutionException before interrupting the task. An explicit retry repeats this until the task finishes independently. Please keep a valid path for these owned cancellation callbacks during final graph cleanup, while retaining the task DB executor until owner release. Add a delayed-cron-barrier + active interruptible schema/OLAP worker regression. A Java 17 extracted-method/latch probe reproduced two rejected retries and recovery after external task completion; this is a remaining recovery gap, not a new regression or evidence of data loss. Score for reviewed head: 8.0/10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
