imbajin commented on code in PR #3326: URL: https://github.com/apache/hugegraph/pull/3326#discussion_r4276288527
########## .github/scripts/dependency-snapshot.py: ########## @@ -0,0 +1,154 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +"""Serialize native Ferstl 4.0.3 graphs; no token or submission code. + +Matches maven-dependency-submission-action 6.0.1's Maven parser/toolkit: +first classifier/type, test scope, shared PURL packages, direct precedence, +child edge order and cycle handling. See docs/ci.md for the producer boundary. +""" + +import datetime +import json +import os +from pathlib import Path +import subprocess +import sys +from urllib.parse import quote + +REPORT = 'maven-dependency-submission-action-depgraph.json' +DETECTOR = {'name': 'maven-dependency-submission-action', 'version': '6.0.1', + 'url': 'https://github.com/advanced-security/maven-dependency-submission-action'} +CORRELATOR = '.github/workflows/submit-dependencies.yml:submit' +SERIALIZER = 'Ferstl 4.0.3; repository stdlib adapter for Maven parser 6.0.1' + + +def unique_object(pairs): + result = {} + for key, value in pairs: + if key in result: + raise ValueError(f'Duplicate JSON key: {key}') + result[key] = value + return result + + +def package_url(artifact): + # packageurl-js uses encodeURIComponent for components and URLSearchParams + # for qualifiers; notably '+' in versions and '/' in namespaces survive. + namespace = '/'.join(part for part in artifact['groupId'].split('/') if part) + name, version = artifact['artifactId'].strip(), artifact['version'].strip() + if not namespace or not name or not version: + raise ValueError('Incomplete Maven coordinates') + encoded_namespace = quote(namespace, safe="!~*'():/") + encoded_name = quote(name, safe="!~*'()") + encoded_version = quote(version, safe="!~*'():+") + purl = f'pkg:maven/{encoded_namespace}/{encoded_name}@{encoded_version}' + qualifiers = {} + for key, field in [('classifier', 'classifiers'), ('type', 'types')]: + values = artifact.get(field) or [] + if values and values[0].strip(): + qualifiers[key] = values[0].strip() + if qualifiers: + purl += '?' + '&'.join(f'{key}={quote(value, safe="*").replace("~", "%7E")}' + for key, value in sorted(qualifiers.items())) + return purl + + +def manifest(graph, pom): + if not isinstance(graph, dict) or not isinstance(graph.get('graphName'), str) or not graph['graphName'].strip(): + raise ValueError(f'Malformed graph name: {pom}') + artifacts, edges = graph.get('artifacts'), graph.get('dependencies') or [] + if not isinstance(artifacts, list) or not artifacts or not isinstance(edges, list): + raise ValueError(f'Empty or malformed graph: {pom}') + if graph.get('dependencies') is not None and not isinstance(graph['dependencies'], list): + raise ValueError(f'Malformed dependency list: {pom}') + ids, packages, scopes = {}, {}, {} + for artifact in artifacts: + if not isinstance(artifact, dict) or any(not isinstance(artifact.get(key), str) or not artifact[key].strip() + for key in ['id', 'groupId', 'artifactId', 'version']): + raise ValueError(f'Malformed artifact: {pom}') + for key in ['scopes', 'types', 'classifiers']: + values = artifact.get(key) + if values is not None and (not isinstance(values, list) or any(not isinstance(x, str) for x in values)): + raise ValueError(f'Malformed artifact {key}: {pom}') + identifier, purl = artifact['id'], package_url(artifact) + if identifier in ids: + raise ValueError(f'Duplicate artifact ID: {identifier}') + ids[identifier] = purl + packages.setdefault(purl, []) + scopes[purl] = 'development' if 'test' in (artifact.get('scopes') or []) else 'runtime' Review Comment: ⚠️ Important. Blocking: yes. Summary: `manifest()` classifies any artifact whose scopes contain `test` as `development`, even when that same artifact also has `compile`, `runtime`, or `provided`. Ferstl 4.0.3 merges scopes onto one artifact node, while the independent inventory treats the package as runtime; the writer then rejects the snapshot on scope mismatch. Please give non-test scopes precedence and add a fixture for a mixed scope array. Evidence: Ferstl `DependencyNode.merge()` combines scopes and `JsonDependencyNodeNameRenderer` emits the combined set; `.github/scripts/dependency-inventory.py:62-69` preserves runtime; `.github/workflows/submit-dependencies.yml:388-390` rejects mismatches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
