bitflicker64 commented on code in PR #822:
URL:
https://github.com/apache/hugegraph-toolchain/pull/822#discussion_r4277810893
##########
hugegraph-loader/assembly/travis/flink-cdc/verify.py:
##########
@@ -258,8 +258,9 @@ def start_flink_mysql(self):
shutil.copyfile(jar, destination)
with jar.open("rb") as stream:
self.report["job_sha256"] = hashlib.file_digest(stream,
"sha256").hexdigest()
- shutil.copyfile(Path(__file__).parents[2] /
"static/bin/hugegraph-flinkcdc-loader.sh",
- job / "bin/hugegraph-flinkcdc-loader.sh")
+ for script in ("hugegraph-flinkcdc-loader.sh", "get-params.sh"):
Review Comment:
Important: This fixture now copies `get-params.sh`, and since #819
`hugegraph-flinkcdc-loader.sh` sources it (line 54) to validate every
submission. But a PR that changes only `get-params.sh` never runs the Flink CDC
lane. In `.github/scripts/ci-policy.py` `optional_checks`, `get-params.sh` sets
`spark_loader` only (lines 105-106), while `flink_cdc` (lines 109-113) lists
the Flink launcher but not its helper. At this head,
`optional_checks(["hugegraph-loader/assembly/static/bin/get-params.sh"])`
returns `flink_cdc: False`, and
`test_engine_launchers_select_only_their_actual_runtime_lane` in
`test_ci_policy.py` (lines 309-318) asserts that result. With `flink_cdc`
false, neither `flink-launcher.test.cjs` nor `packaged-cdc-recovery` runs,
because both live only in `flink-cdc-ci.yml`. So a helper change that breaks
Flink submission, such as a new `return 2` path that the Flink argument shape
hits, would merge with green CI, the same failure this PR repairs. This gap
predates the PR,
which does not widen it. Please add `LOADER +
"assembly/static/bin/get-params.sh"` to the `flink_cdc` condition and change
the `get-params.sh` case in the test to expect both `spark_loader` and
`flink_cdc`, either here or in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
