imbajin commented on code in PR #3352:
URL: https://github.com/apache/hugegraph/pull/3352#discussion_r4285993754
##########
hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh:
##########
@@ -173,12 +173,24 @@ if [[ -n "${PASSWORD:-}" ]]; then
AUTH_ADMIN_PASSWORD_ENCODED=$(encode_auth_prop_value "${PASSWORD}")
fi
+# Same accepted spellings as HG_SERVER_INIT_STORE_ENABLED below, checked
+# before the mapping so an invalid value leaves both conf files untouched.
+# URLs hold no whitespace, and the Server splits the list on bare commas, so
+# "a, b" would otherwise register an escaped space in front of the second URL.
+URLS_TO_PD=$(printf '%s' "${HG_SERVER_URLS_TO_PD:-}" | tr -d '[:space:]')
+DEPLOY_IN_K8S=$(printf '%s' "${HG_SERVER_DEPLOY_IN_K8S:-}" |
+ tr -d '[:space:]' | tr '[:upper:]' '[:lower:]')
Review Comment:
⚠️ Important. Blocking: no. Summary: Removing all whitespace before
validation turns malformed values such as `t rue` into `true`, so startup
accepts a value the new docs say should stop the container. Please trim only
leading and trailing whitespace before lowercasing, and add an
embedded-whitespace invalid case. Evidence: `printf '%s' 't rue' | tr -d
'[:space:]'` yields `true`, which the following allowlist accepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
