bitflicker64 commented on code in PR #3351:
URL: https://github.com/apache/hugegraph/pull/3351#discussion_r4287594731


##########
helm/hugegraph/docs/operations.md:
##########
@@ -293,7 +293,7 @@ Updating chart values alone does not change an existing 
image's behavior.
 | `HG_PD_AUTH_SECRET_KEY` missing | PD Pod Secret reference and key; chart 
injects the shared PD REST password automatically |
 | Server storage wait timeout | Ready PD majority, Store registration, network 
policies and `server.storageWaitTimeoutSeconds` |
 | NodePort/Ingress unreachable | Assigned port, reachable node/controller 
address, firewall and NetworkPolicy rules |
-| REST works but Gremlin reports `Could not rebind` | Run `helm test`; after 
PD stabilizes, replace the failing Server Pod and retry |
+| REST works but Gremlin reports `Could not rebind` | Run `helm test`. Images 
that include apache/hugegraph#3228 rebind Gremlin when REST loads the graph; if 
it persists, check the Server log for `could not be bound in Gremlin Server` or 
`can't be rebound in Gremlin Server`, then replace the failing Server Pod after 
PD stabilizes and retry |

Review Comment:
   Minor: "Images that include apache/hugegraph#3228" names the bug report, not 
the fix. #3228 is the issue, so an operator can read "images that include 
#3228" as "images that have this bug", which is the opposite of what the row 
means. They also cannot check an image tag against an issue number. Could you 
point at the change instead, for example "Images built from source that 
includes apache/hugegraph#3351 (the fix for #3228)", or name the first release 
that ships it once that is known? The log strings in the same row are correct: 
they match the ERROR and WARN in `GraphManager.bindLocalGraph()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to