bitflicker64 commented on code in PR #823:
URL:
https://github.com/apache/hugegraph-toolchain/pull/823#discussion_r4297518695
##########
hugegraph-hubble/hubble-dist/assembly/travis/configure_gremlin_fixture.py:
##########
@@ -47,9 +48,12 @@ def configure(server, fixture):
missing = sorted(name for name in declared if name.replace(".", "/") +
".class" not in available)
if missing:
raise ValueError("Server configuration refers to unavailable classes:
" + ", ".join(missing))
- configured =
fixture.read_text().replace(serializer_block(fixture.read_text()), block, 1)
+ configured = fixture.read_text()
+ for name in ("channelizer", "scriptEngines", "serializers"):
Review Comment:
Minor: hugegraph-server2/gremlin-server.yaml keeps its own `authentication`
block without an `authenticationHandler`. Once this loop copies the native
`WsAndHttpChannelizer`, TinkerPop falls back to its default SASL handler, and
REST Gremlin on server2 stops working. I reproduced it on the 1.8.0 candidate
archive with the server2 template: `GET /gremlin?gremlin=1%2B1` on the REST
port fails with `NoHttpResponseException` from the Gremlin port. With
`HttpChannelizer` the same request returns `[2]`. Adding
`authenticationHandler: org.apache.hugegraph.auth.WsAndHttpBasicAuthHandler`,
which is what the Server's `bin/enable-auth.sh` writes and which 1.7.0 also
ships, makes it return `[2]` again, and Cypher works too. No Hubble job talks
to server2 today, so CI stays green, but this fixture is supposed to keep its
auth working. Adding that line to the server2 template would fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
