bitflicker64 commented on code in PR #533:
URL: https://github.com/apache/hugegraph-doc/pull/533#discussion_r4296836623
##########
content/en/docs/quickstart/hugegraph/hugegraph-helm.md:
##########
@@ -108,6 +140,40 @@ The default mirror inventory is only `hugegraph/pd`,
`hugegraph/store`, `hugegra
Store's PD wait init container and the Helm test reuse Store and Server images
respectively, which already contain `curl`.
No separate curl image or runtime package installation is required. Explicit
`store.waitImage` / `server.waitImage` overrides remain supported.
+### Offline installation and internal repositories
+
+Download the Chart and move the `.tgz` into your network. Install it directly
or upload it to an existing OCI or HTTP repository.
+
+```bash
+CHART=oci://ghcr.io/hugegraph/hugegraph-helm
+CHART_VERSION=0.2.0-dev.14
+helm pull "$CHART" --version "$CHART_VERSION"
+```
+
+```bash {tab="Install archive"}
+helm install hugegraph "./hugegraph-helm-${CHART_VERSION}.tgz" -n hugegraph \
Review Comment:
Minor: The offline install commands still use the default public image
references, so a copied command fails in an air-gapped cluster.
`helm template` on 0.2.0-dev.14 renders `hugegraph/pd`, `store`, `server`
and `hubble` as `:latest` from Docker Hub with `pullPolicy: Always`. With no
image override, Pods stay in ImagePullBackOff and `--wait` runs to the 15m
timeout. The sentence after the tabs mentions overrides, but none of the three
install commands has one. The chart's own `docs/distribution.md` adds `-f
private-images.yaml` at this step.
Add `-f private-images.yaml` (or `--set global.imageRegistry=...`) to the
archive, internal OCI and internal HTTP install commands, and link
`examples/values-internal-registry.yaml`. The CN tabs need the same change.
##########
content/en/docs/quickstart/hugegraph/hugegraph-helm.md:
##########
@@ -108,6 +140,40 @@ The default mirror inventory is only `hugegraph/pd`,
`hugegraph/store`, `hugegra
Store's PD wait init container and the Helm test reuse Store and Server images
respectively, which already contain `curl`.
No separate curl image or runtime package installation is required. Explicit
`store.waitImage` / `server.waitImage` overrides remain supported.
+### Offline installation and internal repositories
Review Comment:
Minor: The new subsection heading swallows the existing storage paragraph.
This heading sits above the unchanged storage text (`For storage, empty
storageClassName ...`, line 177), and no heading follows until section 4. The
storageClassName, local PV and `persistence.enabled` guidance now renders, and
shows in the TOC, under "Offline installation and internal repositories". The
CN page has the same layout (heading at line 138, storage text at line 171).
Move this subsection to the end of section 3, after the storage paragraph,
or give the storage text its own heading, in both languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
