byteayan commented on code in PR #529:
URL: https://github.com/apache/hugegraph-doc/pull/529#discussion_r4297816261


##########
content/en/docs/config/config-guide.md:
##########
@@ -36,7 +36,7 @@ The file-loading behavior on this page was checked against 
Server master commit
 
 Complete defaults are in Server master: 
[gremlin-server.yaml](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/src/assembly/static/conf/gremlin-server.yaml),
 
[rest-server.properties](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties),
 
[hugegraph.properties](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hugegraph.properties),
 and 
[hstore.properties.template](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hstore.properties.template).
 
-The following Docker environment-variable behavior applies only to images 
built from `master`; arbitrary variable names are not converted into 
configuration options. Before initialization and startup, this entrypoint 
processes `HG_SERVER_BACKEND`, `HG_SERVER_PD_PEERS`, `HG_SERVER_USE_PD`, 
`HG_SERVER_CLUSTER`, `HG_SERVER_REST_URL`, `HG_SERVER_MIN_FREE_MEMORY`, 
`HG_SERVER_AUTH_TOKEN_SECRET`, `HG_SERVER_INIT_STORE_ENABLED`, and `PASSWORD`. 
Check the tagged entrypoint for historical release images. See [Docker 
entrypoint](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh).
+The following Docker environment-variable behavior applies only to images 
built from `master`; arbitrary variable names are not converted into 
configuration options. Before initialization and startup, this entrypoint 
processes `HG_SERVER_BACKEND`, `HG_SERVER_PD_PEERS`, `HG_SERVER_USE_PD`, 
`HG_SERVER_CLUSTER`, `HG_SERVER_REST_URL`, `HG_SERVER_URLS_TO_PD`, 
`HG_SERVER_DEPLOY_IN_K8S`, `HG_SERVER_MIN_FREE_MEMORY`, 
`HG_SERVER_AUTH_TOKEN_SECRET`, `HG_SERVER_INIT_STORE_ENABLED`, and `PASSWORD`. 
Check the tagged entrypoint for historical release images. See [Docker 
entrypoint](https://github.com/apache/hugegraph/blob/master/hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh).

Review Comment:
   apache/hugegraph#3352 has merged. I rechecked this page against the 
entrypoint on master (764dd73a4). Whitespace is removed from 
`HG_SERVER_URLS_TO_PD`. `HG_SERVER_DEPLOY_IN_K8S` takes the listed 
case-insensitive spellings, trims only surrounding whitespace, and stops the 
container on anything else. The defaults and the per-URL `http://` note match 
too, so no wording changes were needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to