byteayan commented on PR #3355: URL: https://github.com/apache/hugegraph/pull/3355#issuecomment-6230879191
@imbajin thanks, good catch on the heap-only `-j`. Fixed in 119f819a7: the launcher now adds `-XX:MaxDirectMemorySize=<computed heap>` only when `-j` sets neither `-Xmx` nor `-XX:MaxDirectMemorySize`. With a heap-only `-j` the JVM defaults the cap to that heap, and with an explicit cap the cap applies; the budget counts whichever the JVM reports. `test-start-hugegraph-store.sh` (already run in the store CI job) gains four cases: no `-j` gives the computed 1024m cap, `-j -Xmx512m` and `-j -Xmx4g` leave the cap out, and `-j -XX:MaxDirectMemorySize=256m` ends with 256m. Against the previous launcher both heap-only cases fail with the stale 1024m cap. The deployment guide now describes this path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
