pallavithegod commented on code in PR #3359:
URL: https://github.com/apache/hugegraph/pull/3359#discussion_r4306721459
##########
hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/TaskScheduleService.java:
##########
@@ -275,11 +293,14 @@ public List<Metapb.Partition> patrolPartitions() throws
PDException {
storeService.storeTurnoff(pair.getValue());
partitionService.shardOffline(partition,
pair.getValue().getId());
+ // shardOffline logs its own failures; report a request, not a
completed repair.
+ result.offlineShardRequests.put(partition.getId(),
pair.getValue().getId());
Review Comment:
Fixed in 8ac1d9410. The existing storeTurnoff signature delegates to a
result-returning variant that compares actual shard membership, and patrol adds
those changed IDs without duplicates. Tests cover tombstone changes when the
initial count is correct and when both passes change the same group. A separate
regression also covers leadership loss after scheduling. All 14 focused cases,
clean compilation, RAT, and repository Checkstyle pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
