imbajin commented on PR #826: URL: https://github.com/apache/hugegraph-toolchain/pull/826#issuecomment-6275503881
### Review note: where the large diff comes from The added-line total includes generated dependency notices, the replacement lockfile and extensive validation. It should not be read as that many lines of new application logic. In the current diff against ASF master, rounded figures are: | Area | Added lines | What changed | | --- | ---: | --- | | Frontend license inventories and upstream texts | ~14,400 | Replace obsolete dependency notices with the installed production closure; preserve original grants and record unresolved release follow-ups. | | Test files | ~12,000 | Regression coverage for the controller, migration boundaries, forms, permissions and build validation. | | New pnpm lockfile | ~7,800 | Replace the Yarn lockfile; roughly 12,300 old lockfile lines are removed. | | Frontend application files plus the public visualization module | ~7,000 | The shared model/controller/runtime/React layer and query/algorithm/Schema/card integration, plus UI and library API migration. These areas also remove roughly 8,000 old lines. | Two non-test-looking files, `run_ui_graph_acceptance.js` and `graph_acceptance_helpers.js`, add about 1,600 lines of browser validation rather than shipped application behavior. The local G6 patch adds about 650 lines across the upstream source, ESM and CommonJS copies; it addresses teardown, minimap and PNG correctness. The main product change is a common G6 5 controller and lifecycle across four graph entry points. The other broad change is the explicitly requested toolchain modernization: React/Ant Design compatibility work and the Node/pnpm/Vite build path. Cache scripts verify frontend outputs, Java inputs/SDK identity and distribution contents before reuse. The before/after timings, resource limits and replacement tradeoffs are kept in the PR description. This is still a substantial combined migration. The diff size alone does not prove that its design is minimal; review should concentrate on the shared controller, Hubble adapter/hook and the local G6 patch. Graphs with at most 200 total nodes and edges remain the core target, with no additional large-graph optimization framework. Remaining full acceptance and CI gates stay open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
